Update the theme to material 3, with new search ui, in addition to other smaller changes). #212

caarmen · 2025-01-02T18:23:42Z

Preparation steps

Bump librairies to the latest stable version.
Fix the shell script which disables animations the devices before launching tests.
Improve the way we look up specific RecyclerViews in tests: use a unique resource id for the different RecyclerViews (rhymer result list, thesaurus result list, ...)

UI rework

Migrate from the app compat theme to the material3 theme.
- The accent color is removed. No more yellow.
- The play button looks slightly different.
- The settings/about/license screens have a gray toolbar instead of the primary color toolbar.
Redo the search UI: use the SearchBar + SearchView from the material library, instead of using the platform search widgets. This involves creating our own UI (recyclerview adapter) for the search suggestions.
- The search suggestions appear in a full screen mode.

app/src/main/kotlin/ca/rmen/android/poetassistant/main/dictionaries/search/Search.kt

...src/main/kotlin/ca/rmen/android/poetassistant/main/dictionaries/search/SuggestionsAdapter.kt

...c/main/kotlin/ca/rmen/android/poetassistant/main/dictionaries/search/SuggestionsViewModel.kt

app/src/main/res/layout/activity_settings.xml

app/src/main/res/values/styles.xml

github-actions · 2025-01-02T21:30:02Z

Overall Project	72.85% `-0.29%`	❌
Files changed	90.39%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	90.38% `-1.81%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	71.94% `-0.66%`	❌

github-actions · 2025-01-02T22:03:45Z

Overall Project	78.83% `-0.27%`	❌
Files changed	90.26%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	90.38% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	71.94% `-0.66%`	❌

github-actions · 2025-01-03T00:10:42Z

Overall Project	80.35% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	71.94% `-0.66%`	❌

github-actions · 2025-01-03T01:20:58Z

Overall Project	70.95% `-0.27%`	❌
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	71.12% `-0.66%`	❌

github-actions · 2025-01-03T02:02:05Z

Overall Project	80.46% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	71.94% `-0.66%`	❌

github-actions · 2025-01-03T03:21:23Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

github-actions · 2025-01-03T11:12:40Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

github-actions · 2025-01-03T11:38:36Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

github-actions · 2025-01-03T12:57:07Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

github-actions · 2025-01-03T13:36:53Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

github-actions · 2025-01-03T16:24:22Z

Overall Project	53.44% `-1.52%`	❌
Files changed	45.77%	❌

File	Coverage
FilterDialogFragment.kt	88.66%	🍏
Search.kt	88.57% `-3.27%`	🍏
MainActivity.kt	69.14% `-0.66%`	❌
SuggestionsViewModel.kt	21.71% `-74.29%`	❌
SuggestionsAdapter.kt	16.26% `-76.42%`	❌

github-actions · 2025-01-03T18:13:10Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

etc/screenshots/tablet-7inch/dark/rhymer.png

github-actions · 2025-01-03T19:03:54Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

github-actions · 2025-01-03T20:54:13Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

caarmen · 2025-01-03T21:14:20Z

There is an issue with the composer tab: it doesn't scroll?

github-actions · 2025-01-03T21:25:43Z

Overall Project	80.43% `-0.27%`	🍏
Files changed	90.24%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	72.36% `-0.66%`	❌

…abs. This allows us to more easily (and consistently between robolectric + devices) look for elements in the view hierarchy.

… tests. We were setting values for the wrong animation property names.

Remove: * Custom alert dialog themes. * Custom popup menu header color. * Accent color. Replace the play icon with one that has a transparent triangle inside the circle. Adjust tests to find the play button, after the migration to material3 components. Note that the search theming is not correct in this commit. This is addressed in the next commit.

Use the SearchBar and SearchView provided from the material components library, instead of the appcompat one. Some tests are failing. They are addressed in the following commits.

…he material3 search migration widgets.

…e search widget. TODO: Figure out why the app bar is displayed scrolled up initially.

Instead of having this workaround in tests: prevent the issue in the first place. It was being caused by the query word, in the results list header, being selectable. This was making the app bar scroll up just when opening the app, even if there were no queries yet. Only make this `TextView` selectable if it's from an actual user query.

…reenshots.

…, instead of exiting the app.

… it wasn't possible to scroll to the end of the poem text.

github-actions · 2025-01-04T00:00:30Z

Overall Project	80.3% `-0.46%`	🍏
Files changed	85.15%	🍏

File	Coverage
SuggestionsViewModel.kt	94.29% `-5.71%`	🍏
Search.kt	91.83% `-1.45%`	🍏
FilterDialogFragment.kt	88.66%	🍏
SuggestionsAdapter.kt	84.55% `-15.45%`	🍏
MainActivity.kt	71.01% `-3.02%`	❌

caarmen force-pushed the rewrite-search-ui branch from d1dac6c to ed31f97 Compare January 2, 2025 18:30