Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming: Set the default theme to auto, and archive captured screenshots in github actions. #213

Merged
merged 4 commits into from
Jan 4, 2025
Merged

Theming: Set the default theme to auto, and archive captured screenshots in github actions. #213

merged 4 commits into from
Jan 4, 2025

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Jan 4, 2025 •
edited
Loading

Preparation

Adapt the screenshot test:

  • Convert it to kotlin.
  • Make it parametrized, using the test parameter injector library.
  • Don't @Ignore it anymore.
  • Adapt scripts and github actions to:
    • Run the full test suite except the screenshot test.
    • Run, separately, the screenshot test, and adb pull the saved screenshots.
    • Archive the screenshots in the github action.

Behavior change

Make "auto" the default theme setting, instead of "light".

@caarmen
Make ScreenshotTests parametrized by using the test parameter injecto…
25d7fac 
…r library.

Set the theme programmatically by directly accessing the settings apis, instead of navigating to the settings screen.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Overall Project 79.96% -0.01% ❌
Files changed 80% 🍏

File Coverage
SettingsPrefs.kt 43.9% -0.49% 🍏

@caarmen caarmen force-pushed the set-defalult-theme-auto branch 5 times, most recently from 8eb8191 to ebf12f1 Compare January 4, 2025 19:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@caarmen caarmen force-pushed the set-defalult-theme-auto branch from ebf12f1 to d135b63 Compare January 4, 2025 20:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@caarmen caarmen force-pushed the set-defalult-theme-auto branch from d135b63 to 90541d6 Compare January 4, 2025 20:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@caarmen caarmen force-pushed the set-defalult-theme-auto branch from 90541d6 to a5164dd Compare January 4, 2025 20:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@caarmen caarmen force-pushed the set-defalult-theme-auto branch from a5164dd to 83b5bd2 Compare January 4, 2025 20:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Overall Project 80.3% -0.01% 🍏
Files changed 80% 🍏

File Coverage
SettingsPrefs.kt 43.9% -0.49% 🍏

@caarmen caarmen marked this pull request as ready for review January 4, 2025 21:43
@caarmen caarmen force-pushed the set-defalult-theme-auto branch from 83b5bd2 to ab69ba1 Compare January 4, 2025 21:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Overall Project 80.3% -0.01% 🍏
Files changed 80% 🍏

File Coverage
SettingsPrefs.kt 43.9% -0.49% 🍏

@caarmen caarmen changed the title Set defalult theme auto Theming: Set the default theme to auto, and archive captured screenshots in github actions. Jan 4, 2025
@caarmen caarmen merged commit cc52c43 into master Jan 4, 2025
3 checks passed
@caarmen caarmen deleted the set-defalult-theme-auto branch January 4, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caarmen