Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More adjustments related to scrolling... #214

Merged
merged 5 commits into from
Jan 5, 2025
Merged

More adjustments related to scrolling... #214

merged 5 commits into from
Jan 5, 2025

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Jan 5, 2025

  • Add comments to scrolling configurations/workarounds, to explain each scenario they address.
  • Revert the "back pressed" handler which expanded the app bar. It was causing some issues on Android 21, where it was impossible to leave the editor. When you closed the keyboard, the app bar was only partially expanded, and then went back up. It wasn't possible to drag it down, so it was not possible to access it.
  • Add windowSoftInputMode=adjustPan, so that as you continue to type a poem, you continue to see what you're typing (it isn't covered by the keyboard).
  • Use NestedScrollView instead of ScrollView with nestedScrollingEnabled. Maybe this can in theory bring better support to older Android versions?

Copy link

github-actions bot commented Jan 5, 2025

Overall Project 80.43% 🍏
File Coverage
MainActivity.kt 72.36% 🍏

@caarmen caarmen changed the title More scrolling More adjustments related to scrolling... Jan 5, 2025
Copy link

github-actions bot commented Jan 5, 2025

Overall Project 80.43% 🍏
File Coverage
MainActivity.kt 72.36% 🍏

@caarmen caarmen marked this pull request as ready for review January 5, 2025 01:14
@caarmen caarmen merged commit 463fafe into master Jan 5, 2025
3 checks passed
@caarmen caarmen deleted the more-scrolling branch January 5, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant