ESLint migration to v9 #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the eslint group with 4 updates: [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest), [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react), [eslint-plugin-simple-import-sort](https://github.com/lydell/eslint-plugin-simple-import-sort) and [eslint](https://github.com/eslint/eslint). Updates `eslint-plugin-jest` from 27.9.0 to 28.2.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v27.9.0...v28.2.0) Updates `eslint-plugin-react` from 7.34.0 to 7.34.1 - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/v7.34.1/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.34.0...v7.34.1) Updates `eslint-plugin-simple-import-sort` from 12.0.0 to 12.1.0 - [Changelog](https://github.com/lydell/eslint-plugin-simple-import-sort/blob/main/CHANGELOG.md) - [Commits](lydell/eslint-plugin-simple-import-sort@v12.0.0...v12.1.0) Updates `eslint` from 8.57.0 to 9.1.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.1.0) --- updated-dependencies: - dependency-name: eslint-plugin-jest dependency-type: direct:production update-type: version-update:semver-major dependency-group: eslint - dependency-name: eslint-plugin-react dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: eslint-plugin-simple-import-sort dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major dependency-group: eslint ... Signed-off-by: dependabot[bot] <[email protected]>
added 2 commits
September 9, 2024 15:26
added 12 commits
November 29, 2024 11:10
| @@ -24,15 +24,16 @@ yarn add --dev @cabify/eslint-config eslint prettier | |||
|
|
|||
| ## Usage | |||
|
|
|||
| 1. Create a `.eslintrc` file at the root of your project: | |||
| 1. Create a `.eslint.config.js` file at the root of your project: | |||
There was a problem hiding this comment.
Please, review if we can define the config in a ts file
There was a problem hiding this comment.
According to the eslint doc create an eslint.config.ts is an experimental feature.
In my opinion, we should keep the files as .js until we can configure without experimental options.
ref1
| @@ -0,0 +1,65 @@ | |||
| const globals = require('globals'); | |||
There was a problem hiding this comment.
Can't you use an ESmodule file for this?
It question applies to all configuration files.
There was a problem hiding this comment.
I see there are config files in ESmodule as well.
I don't understand why we need to define the config in both formats 🤷
| @@ -1,6 +1,7 @@ | |||
| const confusingBrowserGlobals = require('confusing-browser-globals'); | |||
There was a problem hiding this comment.
Could all these config filers use a ts file instead of js?
| @@ -0,0 +1,4 @@ | |||
| // eslint-disable-next-line import/extensions | |||
There was a problem hiding this comment.
Could you check if we can use a ts file to define the config?
| } | ||
| }, | ||
| }; | ||
| /* eslint-disable import/prefer-default-export */ |
There was a problem hiding this comment.
Why not a ts file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint Migration to v9
This MR updates our shared ESLint configuration to align with version 9 standards.
Key Changes:
This update ensures our configuration stays compatible with the latest ESLint features and best practices.