fix: cookie vulnerability #511
Closed
+313
−625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraMansori
force-pushed
the
fix/dep-vulnerability
branch
from
f4d6aa8 to
544ce34
Compare
|
Closing this PR as the vulnerability has been fixed in #516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently we have a dependency with a low security vulnerability (
cookie)https://github.com/cabify/prom-react/security/dependabot/22
Solution
We are currently using the version 0.4.2 of the library
cookie(not directly, but the project hasmswas a dependency andmswhascookieas a dependency pinned to the version 0.4.2).We cannot upgrade directly the version of
cookieto the earliest fixed version (0.7.0), so we have to upgrademsw. The next version ofmswis the 2.0.0, which means a major upgrade with various breaking changes.For this we have to upgrade
mswfollowing this guide