Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage.md: add an explanation about header-only libs #1073

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

Heus-Sueh
Copy link
Contributor

@Heus-Sueh Heus-Sueh commented Jan 2, 2025

usage.md: add an explanation about header-only libraries in the Install dependencies section

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one thing, looks good.

docs/usage.md Show resolved Hide resolved
@ken-matsui
Copy link
Member

For the PR title, use a present tense, i.e., add instead of adding.

@ken-matsui
Copy link
Member

For the PR description, make sure to follow https://github.com/cabinpkg/cabin/blob/main/CONTRIBUTING.md#commit-message. You can also refer to this: https://git-scm.com/docs/SubmittingPatches#describe-changes.

@Heus-Sueh Heus-Sueh changed the title usage.md: adding an explanation about header-only libs usage.md: add an explanation about header-only libs Jan 3, 2025
@ken-matsui ken-matsui merged commit 3bc77c6 into cabinpkg:main Jan 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants