Add subcmd add
#914
Merged
Add subcmd add
#914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken-matsui
reviewed
Feb 24, 2024
SunPodder
force-pushed
the
add_cmd
branch
2 times, most recently
from
213f43c to
2d3f608
Compare
ken-matsui
reviewed
Feb 24, 2024
|
All fixed including the clang-tidy error |
|
@SunPodder Sorry, there are more clang-tidy errors. Could you please address them? (After that, LGTM) |
SunPodder
force-pushed
the
add_cmd
branch
2 times, most recently
from
f6573ac to
a06df02
Compare
ken-matsui
reviewed
Feb 25, 2024
ken-matsui
reviewed
Feb 25, 2024
ken-matsui
reviewed
Feb 25, 2024
Allows users to add project dependencies to poac.toml from the commandline
|
Sorry, it must be annoying for you reviewing the same mistakes. clang-tidy throws errors on my machine even for existing codes which are correct and passes on ci. So it's hard to make sure everything is fine :) |
|
No worries! Which version of clang-tidy are you using? |
clang-tidy-15 |
|
It seems that clang-tidy-17 fixed the problem, just fyi: llvm/llvm-project#46097. |
ken-matsui
approved these changes
Feb 25, 2024
|
@SunPodder Can you also update README.md for this command? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.