Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed for libgit2 1.8 #920

Merged
merged 5 commits into from
May 6, 2024
Merged

Fixed for libgit2 1.8 #920

merged 5 commits into from
May 6, 2024

Conversation

How2PlayGithub
Copy link
Contributor

Fixed for libgit2:1.8.0-2

The error functions and enumeration values have been renamed for consistency. The giterr_ functions and values prefix have been renamed to be prefixed with git_error_; similarly, the GITERR_ constants have been renamed to be prefixed with GIT_ERROR_. The old enumerations and macros will be retained for backward compatibility for the foreseeable future.

https://github.com/libgit2/libgit2/blob/main/docs/changelog.md

@How2PlayGithub
Copy link
Contributor Author

I had this error today and found that I just needed to change it to giterr_clear for it make

ken-matsui
ken-matsui requested changes May 6, 2024
View reviewed changes
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! It seems that libgit2 is not following SemVer... Just a nit, please keep the newline before the namespace end. Otherwise, it looks good to me.

src/Git2/Exception.cc Outdated Show resolved Hide resolved
@How2PlayGithub How2PlayGithub requested a review from ken-matsui May 6, 2024 11:22
ken-matsui
ken-matsui approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ken-matsui ken-matsui merged commit 97b43cb into cabinpkg:main May 6, 2024
14 checks passed
@yaito3014 yaito3014 mentioned this pull request May 29, 2024
Closed
@ken-matsui ken-matsui mentioned this pull request Jul 21, 2024
Merged
ken-matsui added a commit that referenced this pull request Jul 21, 2024
@ken-matsui
Drop libgit2 >=1.9 support (#946)
4a52151 
Related to: #920,
#930

This is because they don't follow SemVer.
@ken-matsui ken-matsui mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ken-matsui ken-matsui ken-matsui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@How2PlayGithub @ken-matsui