Fix nil check in Nebulex.Adapters.Multilevel.get/3 (#205)

Co-authored-by: Niels Henrik Egsgaard <[email protected]>
cabol · May 25, 2023 · c6d8d18 · c6d8d18
1 parent 909b967
commit c6d8d18
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/nebulex/adapters/multilevel.ex b/lib/nebulex/adapters/multilevel.ex
@@ -313,10 +313,12 @@ defmodule Nebulex.Adapters.Multilevel do
   @impl true
   defspan get(adapter_meta, key, opts) do
     fun = fn level, {default, prev} ->
-      if value = with_dynamic_cache(level, :get, [key, opts]) do
-        {:halt, {value, [level | prev]}}
-      else
+      value = with_dynamic_cache(level, :get, [key, opts])
+
+      if is_nil(value) do
         {:cont, {default, [level | prev]}}
+      else
+        {:halt, {value, [level | prev]}}
       end
     end
 

diff --git a/test/nebulex/adapters/multilevel_inclusive_test.exs b/test/nebulex/adapters/multilevel_inclusive_test.exs
@@ -68,6 +68,14 @@ defmodule Nebulex.Adapters.MultilevelInclusiveTest do
       assert Multilevel.get(3, level: 2) == 3
     end
 
+    test "get boolean" do
+      :ok = Multilevel.put(1, true, level: 1)
+      :ok = Multilevel.put(2, false, level: 1)
+
+      assert Multilevel.get(1) == true
+      assert Multilevel.get(2) == false
+    end
+
     test "fetched value is replicated with TTL on previous levels" do
       assert Multilevel.put(:a, 1, ttl: 1000) == :ok
       assert Multilevel.ttl(:a) > 0