Skip to content

Feature/exec pipeline #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cacapon merged 24 commits into from
Apr 29, 2025
Merged

Feature/exec pipeline #183

cacapon merged 24 commits into from
Apr 29, 2025

Conversation

@dayano74
Copy link
Collaborator

@dayano74 dayano74 commented Apr 29, 2025

  • 外部コマンドとパイプでコマンドを実行する処理を実装しました

  • 挙動は./minishelを実行して確認してほしいです。testerは作成していません。

  • ビルトインコマンドは未実装です。

  • シグナルで終了させられたときの処理は未実装です。

dayano74 added 24 commits April 28, 2025 12:15
@dayano74
rebase process inside while loop
dbc7bd4
@dayano74
add space for other exit status
7d0f365
@dayano74
add exit status of cmd failed
30a8946
@dayano74
update execute_cmd
c38852a
@dayano74
update is_xx
8bdb497
@dayano74
Merge branch 'main' into feature/exec_pipeline
838eae0
@dayano74
update redirect_stdout func
2070728
@dayano74
add redirect.h
0ac6a80
@dayano74
update redirect funcs
36e2eae
@dayano74
fix return value to test execpipe_line function
f6cc0d7
@dayano74
fix execpipe_line
9a6b46a
@dayano74
add lib to use waitpid in wait_pipeline func
e5cd850
@dayano74
update wait_pipeline
b1ff58e
@dayano74
Merge branch 'main' into feature/exec_pipeline
2a4209f
@dayano74
fix exit status
7f53ead
@dayano74
update wait_pipeline
33173f2
@dayano74
add print error
54aba45
@dayano74
add lib to use waitpid
41641bc
@dayano74
add error.h
6e34ab2
@dayano74
add print_error
ed34a05
@dayano74
change pid type: int -> pid_t
b162514
@dayano74
fix files and codes to be under the norm
07220a7
@dayano74
fix under the norm
e47a8e6
@dayano74
Merge branch 'main' into feature/exec_pipeline
e25054b
@cacapon cacapon mentioned this pull request Apr 29, 2025
Closed
@cacapon
Copy link
Owner

cacapon commented Apr 29, 2025 •
edited
Loading

cat src/main.c | wc -lが動作しない
パイプの動作がやや怪しそう

@cacapon
Copy link
Owner

cacapon commented Apr 29, 2025

time sleep 3 | sleep 5 | sleep 4 ３秒になる
ただ、挙動的に別扱いになりそうで難しそう…

cacapon
cacapon approved these changes Apr 29, 2025
View reviewed changes
Copy link
Owner

@cacapon cacapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一部想定通りに動いていない箇所がありますが、
別途対応するということで一旦OKにします。

コメントで残していた部分は別issueを立ち上げるので、対応していきましょう！

This was referenced Apr 29, 2025
Closed
Open
@cacapon cacapon merged commit 12d1e0a into main Apr 29, 2025
1 check passed
@cacapon cacapon deleted the feature/exec_pipeline branch April 29, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cacapon cacapon cacapon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dayano74 @cacapon