191 invoke cmd handle built in command #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
レビューは続けますので、resolveの解消はお願いします〜 |
Collaborator
Author
解消できました。 |
cacapon
approved these changes
May 4, 2025
Owner
cacapon
left a comment
cacapon
left a comment
There was a problem hiding this comment.
疑問点について理解できました。回答ありがとうございます。
OKだと思うのでマージさせていただきますね。お疲れ様でした！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ビルトインのコマンドを実行する処理を追加しました。
./minishellで試してください。builtinのexitがargcが1のときしか許していなかったので、argcが2の時も動作するようにしました。
argc=2の時も実行できる処理を実装するため、fd_strtolとfd_strtollを追加しました。