add signal function #219
Merged
add signal function #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayano74
commented
May 5, 2025
| { | ||
| (void)signum; | ||
| printf("\n"); | ||
| write(STDOUT_FILENO, "\n", 1); |
Collaborator
Author
There was a problem hiding this comment.
writeのほうがシステムコールを呼び出しているだけなので、安全だそうです。
POSIX 標準で「シグナルハンドラ内から呼んで安全」とされる関数群
https://man7.org/linux/man-pages/man7/signal-safety.7.html?utm_source=chatgpt.com
cacapon
approved these changes
May 5, 2025
Owner
cacapon
left a comment
cacapon
left a comment
There was a problem hiding this comment.
基本的な挙動はOKです。
ただ、ちょっとbashと挙動が異なる動きを見つけました。
$ sleep 3 | sleep 5 | sleep 4のように複数コマンドがあると改行やQuit (core dumpd)が複数表示されます。
こちらについては別のissueで対応しましょう。
Collaborator
Author
|
あ、そのパターンは想定していませんでした。イシューで対応わかりました。 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
外部コマンド実行中にシグナルを受け取った時の処理を追加しました。
./minishellで試してください。