Feature/215 fix expand env #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayano74
approved these changes
May 6, 2025
Collaborator
dayano74
left a comment
dayano74
left a comment
There was a problem hiding this comment.
展開されないことを確認しました。大丈夫だと思います。
dayano74
approved these changes
May 6, 2025
dayano74
previously approved these changes
May 6, 2025
Collaborator
|
approveしてもマージされないのはwipされているからですか？ |
Owner
Author
|
はい、今ドラフトで作ってるからですね。 これは今回の対応で新しく出たバグなので、その対応が終わったら改めてレビューさせてください。 |
dayano74
approved these changes
May 9, 2025
Collaborator
dayano74
left a comment
dayano74
left a comment
There was a problem hiding this comment.
3パターンの形式を複数試しました。大丈夫だと思います！修正ありがとうございます。
echo $SHELL
echo "$SHELL"
echo '$SHELL'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #215
対応内容
今までの対応で'＄SHELL'のようなシングルクオートで囲まれていた文字が展開されるようになってしまったので、
展開されないように修正をしています。
現時点の対応だとhe's cool!のような閉じていない文字でsyntax errorになってしまうので、対応中です。対応しました。レビュー可能です。
確認方法
./minishで確認できます。