リダイレクト失敗時にbuiltin関数を実行しないように修正 #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2025 11:46
dayano74
approved these changes
May 9, 2025
Collaborator
dayano74
left a comment
dayano74
left a comment
There was a problem hiding this comment.
ありがとうございます。bashと同様の動作を確認しました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #225
対応内容
リダイレクト失敗時に結果の成否に関わらずビルトイン関数が実行される状態になっていましたので、
boolとして結果を返し、呼び出し元もそれにあわせて後続の処理を実行しないようにしました。
確認方法
./minishell実行後、下記の点についてご確認いただけたらと思います。echo > <書き込み権限がないファイル>でminish: <file>: Permission deniedのみ表示されるかecho $?で1が表示されるか備考