add process that validates command path #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #253
ft_strchrを追加し、入力されたコマンドに
/が存在した時、accessでファイルが存在するか検証するようにした。カレントディレクトリにコマンド（以降、コマンドをcatとして考える）と同じ名前のファイルがあるときは、get_cmd_pathのaccess(cmd, F_OK)は成功するが、execute_cmdのaccess(fullpath, X_OK)は失敗し、 Permission deniedのエラーメッセージが出力される。
カレントディレクトリにcatと同じ名前のファイルがないときは、そもそもget_cmd_pathのaccess(cmd, F_OK)の確認には至らず、fullpathが作成される。そして、execute_cmdでcatが実行される。