Feature/more-currencies-support #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachebag
requested changes
Jan 18, 2026
Owner
There was a problem hiding this comment.
Looks good!
I'm curious, do we not need any changes to the backend schema here? I guess this is more of an architectural matter- we could simply store ALL currency as USD but merely change the frontend for use friendliness. What do you think?
Add Playwright testing dependency.
Also I don't see this being used anywhere. What was the reason for adding it?
cachebag
added
feature
diabawii
force-pushed
the
feature/master-1768740547573-a28t
branch
from
9591b5d to
0873219
Compare
This was referenced Jan 21, 2026
cachebag
pushed a commit
that referenced
this pull request
Jan 21, 2026
* chore: Add more currencies and refactor currency formatting * feat: Add support for MYR, EGP, and SAR currencies with explicit save action
cachebag
added a commit
that referenced
this pull request
Jan 21, 2026
* Feature added spending items allow for automatic savings, with it being in budget allows flexibility * Removed the explainers * Adjusted visuals * Impovemnet to budget to saving branch * Improved Visuals * Removed explainers * Fixed handling of item savings destination and updated frontend display. * Removed explainers * refresh trigger added * Fix double spending issue and CI failures * Ran cargo fmt to ensure proper formatting per CI requirements * Feature/more-currencies-support (#18) * chore: Add more currencies and refactor currency formatting * feat: Add support for MYR, EGP, and SAR currencies with explicit save action * Addressed docker build issues * Ignore frontend/package-lock.json and remove from tracking * Added to .gitignore * Fix double spending issue and CI failures * Update frontend/src/components/ItemsSection.tsx Co-authored-by: Copilot <[email protected]> * Update frontend/src/components/ItemsSection.tsx Co-authored-by: Copilot <[email protected]> * fix: build errors and database migration logic --------- Co-authored-by: ahmed <[email protected]> Co-authored-by: akrm <[email protected]> Co-authored-by: Copilot <[email protected]>
cachebag
added a commit
that referenced
this pull request
Jan 21, 2026
* Feature added spending items allow for automatic savings, with it being in budget allows flexibility * Removed the explainers * Adjusted visuals * Impovemnet to budget to saving branch * Improved Visuals * Removed explainers * Fixed handling of item savings destination and updated frontend display. * Removed explainers * refresh trigger added * Fix double spending issue and CI failures * Ran cargo fmt to ensure proper formatting per CI requirements * Feature/more-currencies-support (#18) * chore: Add more currencies and refactor currency formatting * feat: Add support for MYR, EGP, and SAR currencies with explicit save action * Addressed docker build issues * Ignore frontend/package-lock.json and remove from tracking * Added to .gitignore * Fix double spending issue and CI failures * Update frontend/src/components/ItemsSection.tsx Co-authored-by: Copilot <[email protected]> * Update frontend/src/components/ItemsSection.tsx Co-authored-by: Copilot <[email protected]> * fix: build errors and database migration logic --------- Co-authored-by: ahmed <[email protected]> Co-authored-by: akrm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary