Skip to content

Conversation

pzheltov
Copy link

Instead of "checking" if formatting is correct, cmake-format should format the files with --in-place.

Copy link
Member

@sandydoo sandydoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only missing the upgrade story for configPath.

type = types.submodule {
imports = [ hookModule ];
options.settings = {
configPath = mkOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configPath should be deprecated and added to config-files to allow people to migrate.

@sandydoo sandydoo added the enhancement New feature or request label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants