docs: sync needle run --temperature and finetune --generate options - #95
Open
LeonSGP43 wants to merge 1 commit into
Open
docs: sync needle run --temperature and finetune --generate options#95LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
- llms.txt: CLI summary entry for 'needle run' lists --checkpoint/--query/ --tools but omits --temperature, which was wired through in cactus-compute#88 (default 0.0, greedy; values above 0 sample via jax categorical). - doc/finetuning.md: document the inline generator options of 'needle finetune' (--generate/--model/--workers), already covered in README and llms.txt but absent from the finetuning deep dive. Signed-off-by: LeonSGP43 <leonsgp43@users.noreply.github.com>
Contributor
Author
|
Hi! Just following up briefly on this one — it's been a couple of days since submission, so wanted to check it's on the review radar. Both syncs ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two documentation sync gaps between the CLI (as of
4ac96b1/ #88 and25ef4ac/ #93) and the docs:llms.txt CLI summary omits
needle run --temperature. The entry lists--checkpoint/--query/--tools, but fix: wire --tools and --temperature through needle run, drop dead --no-constrained flag #88 wired--toolsand--temperaturethroughneedle run. Only--temperatureis missing from the summary.doc/finetuning.md does not mention the inline generator options of
needle finetune.--generate <n>(synthesize N extra examples via OpenRouter before training),--model <id>(defaultdeepseek/deepseek-v4-flash), and--workers <n>(default 8) are documented in README ("Key options" list) and llms.txt, but the finetuning deep dive — the doc that explains exactly this pipeline, including "when validation loss rises, add data" — never mentions the built-in synthesis path. It only covers the separategenerate-datacommand.Evidence
needle/cli.py,runsubparser:--temperature,type=float, default=0.0, help="Sampling temperature (0 = greedy)".needle/model/run.pygenerate():temperature <= 0.0→argmax(greedy); above 0 →jax.random.categorical(logits / temperature).needle/cli.py,finetunesubparser:--generate(default=0, "Generate N extra examples via OpenRouter before training (0 = off)"),--model(default="deepseek/deepseek-v4-flash"),--workers(default=8).Changes
llms.txt: add[--temperature <t>]to theneedle runentry with a short "defaults to 0 (greedy)" clause, matching the bracketed-optional-flag style of the neighbouring entries.doc/finetuning.md: one sentence after thegenerate-datablock describing--generate/--model/--workers, using only facts verifiable from the CLI definitions.Docs only; no code paths touched.