Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #12

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Update README #12

merged 1 commit into from
Apr 2, 2020

Conversation

mohammed90
Copy link
Member

  • Update the build instructions in the README by opting for using the xcaddy command, so we can remove the build script.

  • Better word choice in the README of the context->directive file generators.

Closes #11

mholt
mholt approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is much better! 😃

@mohammed90 mohammed90 merged commit 5415866 into master Apr 2, 2020
@mohammed90 mohammed90 deleted the update-build branch April 2, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to build
2 participants
@mohammed90 @mholt