Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide helper script to build Caddy with nginx adapter #6

Merged
merged 3 commits into from
Feb 25, 2020

Conversation

mohammed90
Copy link
Member

There have been 2 reports (#5 and https://caddy.community/t/howto-use-nginx-config-adapter/6929) of difficulties to build Caddy with the nginx adapter. This PR provides a helper script to do just that.

@mohammed90 mohammed90 requested a review from mholt February 24, 2020 23:05
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, great start! As you said, will need some instructions. I just have a couple questions but nothing stands out to me as incorrect/flawed.

@mohammed90 mohammed90 requested a review from mholt February 25, 2020 20:22
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great! Thank you!!

@mholt mholt merged commit 6c48455 into master Feb 25, 2020
@mohammed90 mohammed90 deleted the build-helper branch February 25, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants