Update Caddy dependency #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Caddy v2.0.0-beta.20, the split_path config parameter takes a slice/array. This commit adapt to the change. Through adapting to the update, a bug in processing `fastcgi_split_path_info` was found. The `fastcgi_split_path_info` directive in NGINX takes a regexp with 2 capture groups: the first is for the CGI script file name including its extension, and the second is for PATH_INFO. Before this commit, the directive was treated as if it takes the extension of the script file. The fix in this commit finds the extension by looking for a period followed by a series of alphanumeric characters, and uses that as our split_path paramter.
mholt
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Caddy v2.0.0-beta.20, the split_path config parameter takes a slice/array. This commit adapt to the change.
Through adapting to the update, a bug in processing
fastcgi_split_path_infowas found. Thefastcgi_split_path_infodirective in NGINX takes a regexp with 2 capture groups: the first is for the CGI script file name including its extension, and the second is for PATH_INFO. Before this commit, the directive was treated as if it takes the extension of the script file. The fix in this commit finds the extension by looking for a period followed by a series of alphanumeric characters, and uses that as our split_path paramter.