Handle scheme-less upstreams properly #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… previously didn't account for this. Now we check if there's scheme marker, and prefix the address with `tcp://` if not. Some accommodation was necessary for the special case of unix socket addresses.
mholt
reviewed
Apr 1, 2020
| * If upstream doesn't have scheme explicitly specified as scheme://host, then | ||
| * assume it's tcp by prefixing it with tcp://. Later we check if the hostname is `unix:`. | ||
| * If so, then the arguemnt of fastcgi_pass was of the form `unix:/some/path`. | ||
| **/ |
There was a problem hiding this comment.
Just curious, why the block style comment here? 🤔
There was a problem hiding this comment.
Laziness 😂 didn't feel like double tapping the forward slash key
mholt
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url.Parsereturns an error if the argument is an IP address. The code previously didn't account for this. Now we check if there's scheme marker, and prefix the address withtcp://if not. Some accommodation was necessary for the special case of unix socket addresses.Fixes #8