Refactor CassandraPersistence to split out Task and Shard Persistence #3623
+905
−827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
qlong-nosql-execition
branch
2 times, most recently
from
e737611 to
6ff254f
Compare
yux0
approved these changes
Oct 12, 2020
github-actions
bot
force-pushed
the
qlong-nosql-execition
branch
from
d241b67 to
ce091c4
Compare
github-actions
bot
force-pushed
the
qlong-nosql-execition
branch
from
ce091c4 to
4a07701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor CassandraPersistence to split out Task and Shard Persistence
Why?
for #3514
The cassandraPersistence implements three different Stores today, it's too difficult/risky if I refactor them together for NoSQL support. Hence I split it into three and then do it one by another.
How did you test it?
Use existing tests.
Potential risks
Very minimal risk as no any logic change, just moving code from one to anther file.