[Wf-Diagnostics] Incorporate blob size limits in diagnostics workflow #6583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
dkrotx
reviewed
Jan 6, 2025
| for _, issue := range issues { | ||
| if issue.InvariantType == failure.ActivityFailed.String() || issue.InvariantType == failure.WorkflowFailed.String() { | ||
| if issue.InvariantType == failure.ActivityFailed.String() || issue.InvariantType == failure.WorkflowFailed.String() || issue.InvariantType == failure.DecisionCausedFailure.String() { |
There was a problem hiding this comment.
I'd recommend making a function like haveFailureMetadata, otherwise it becomes a long if-list and it is not super-clear why these particular issues are special?
dkrotx
approved these changes
Jan 6, 2025
| RootCauseType: rc.RootCause.String(), | ||
| }) | ||
| } | ||
| if rc.RootCause == invariant.RootCauseTypeBlobSizeLimit { |
There was a problem hiding this comment.
A bit unexpected data-model here: I would expect individual rootcause to populate their data, and then this data to be marshalled similarly across different rootCauses, but here different fields of the failureRootCauseResult are populated depending on different type.
There was a problem hiding this comment.
agreed. will discuss offline to refactor this better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Diagnostics workflow includes blob size limit related failures
Why?
adding the blob size usecase for diagnostics
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes