panic fix: no version histories is mutable state #6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having no version histories is considered OK by `getMutableState` which
has:
```
if versionHistories != nil {
retResp.VersionHistories = versionHistories.ToInternalType()
}
```
Which means, PollMutableState/GetMutableState should not panic on this.
It is now returning error instead.
Looks like we're dealing with corrupted workflows (left a corresponding
comment).
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Not panicing on GetMutableState and no version histories
Why?
Having no version histories is considered OK by
getMutableStatewhichhas:
Which means, PollMutableState/GetMutableState should not panic on this.
It is now returning error instead.
Looks like we're dealing with corrupted workflows (left a corresponding
comment).
How did you test it?
A new unit-test
Potential risks
Change should be transparent as the corruption error should always be expected.
Release notes
Documentation Changes