Fix width and height returned by size() when displays are rotated 90° and 270° #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d) when rotating displays 90 and 270 degrees.
caemor
reviewed
Apr 5, 2022
| @@ -39,7 +39,8 @@ impl DrawTarget for Display1in54 { | |||
|
|
|||
| impl OriginDimensions for Display1in54 { | |||
| fn size(&self) -> Size { | |||
| Size::new(WIDTH, HEIGHT) | |||
| let (w, h) = self.dimensions(); | |||
| Size::new(w.into(), h.into()) | |||
There was a problem hiding this comment.
The intos are not needed since w and h are already u32.
|
Thanks for the PR. If you have the time and interest, this could be improved even more by adding a default implementation for the |
|
@caemor Should I also change functions like |
|
Sure that would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #104 where
embedded-graphicstext alignment features were not working because thesize()method wasn't taking display rotation into account.