-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform Compatibility #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Amazing work so far.
Just a little maintainability improvements here and there.
As for tests, they will be implemented in another PR that closes #26 (currently waiting for this pr) |
@LyubomirT I can also send a PR over if you need help with it |
No need for that just yet, I'll handle it. Appreciate the feedback nonetheless! |
Applied all your requested changes, please review the code again, if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll go ahead and update linting CI before merging |
Okay! Take your time. |
Looks like merging into main won't affect the CI here. |
I'm not sure if I did this correctly, but it seems to have worked. Please check if everything is in order? |
Yep! No issues with linting anymore. Just some permission issues for my labeler GHaction 🥲 |
Thank you for your contribution!! (●´□`)♡ |
82c7edd
into
caffeine-addictt:main
What type of PR is this? (check all applicable)
Description
As discussed in #23, I rewrote the code using Node.js and optimized it for all platforms using platform-independent methods built into Node.js. This has no dependencies and requires nothing but
node
to be installed (I used v20.11.0 for this, but since there is a deprecation issue,rmSync
may not work on older versions. But it's easily resolvable). It does pretty much the same as the original.sh
file. HOWEVER, I've noticed that theCITATION.cff
file doesn't work properly with the placeholder replacement algorithm, due to how {{PROJECT_NAME}} and {{NAME}} placeholders are formatted in it, so I had to fix that as well. (changed the template). Honestly, I'm not very proud of how I wrote this, so any feedback or criticism is much appreciated. I hope this code works for you!Related Tickets & Documents
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
Don't think so.
Checklist
(I trust it should be updated after my code is reviewed)