Skip to content

Conversation

@caitp
Copy link
Owner

@caitp caitp commented Nov 14, 2019

No description provided.

@caitp
Copy link
Owner Author

caitp commented Nov 14, 2019

@nonara so adding the type definition file is interfering with instrumenting the library for coverage :( This should be fixable with fishbar/jscoverage#45 merged (at which point it will be possible to exclude *.ts files).

In the mean time, you could try to get this in the @types registry

@caitp caitp merged commit 892f976 into master Nov 14, 2019
@caitp caitp deleted the FixupCI branch November 14, 2019 19:26
@nonara
Copy link
Contributor

nonara commented Nov 14, 2019

@caitp Interesting! Nice work on the fixes. I recently moved from mocha, chai, nyc, rewire, & sinon over to Jest. I'm usually quite hesitant to change from a proven tool to a newer one, and I generally don't like Facebook.

With that said, Jest has not ceased to impress! Spies, mocks, coverage, TS integration, etc - all seamless and built-in. Overall, it's also just built very well. Many improvements. If you've not had a chance yet, you might enjoy it for a future project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants