Add migration notes for Configure attribute #8095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
force-pushed
the
container-attribute
branch
3 times, most recently
from
6dfb593 to
9baf482
Compare
|
Is there a generic container section we should add this to? |
There is this page https://book.cakephp.org/5/en/development/dependency-injection.html |
othercorey
force-pushed
the
container-attribute
branch
2 times, most recently
from
d2c6018 to
477226b
Compare
othercorey
commented
Sep 22, 2025
| public function __construct( | ||
| #[Configure('MyService.apiKey')] protected string $apiKey, | ||
| ) { } | ||
| } |
There was a problem hiding this comment.
Should I add a link to the dependency injection docs instead?
ADmad
reviewed
Sep 22, 2025
othercorey
force-pushed
the
container-attribute
branch
from
477226b to
bbd3a7a
Compare
othercorey
force-pushed
the
container-attribute
branch
from
bbd3a7a to
fb70334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs cakephp/cakephp#18911