-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response: set the content type to application/json #349
Conversation
a271c9f
to
a963a2f
Compare
* Convert to ARC
a963a2f
to
a4da33e
Compare
Ready for review. |
I'd like to understand why UTF-8? Don't non-ascii languages like Japanese and Chinese rely on UTF-16? Is there an advantage to limiting the bits? |
I think all Japanese and Chinese characters have a UTF-8 equivalent. That is to say, every character can be represented. In recent memory, I have interacted with one Japanese and one Chinese user around encodings - UTF-8 was good enough. With that said, I am not an encoding expert. I have had to deal with UTF 16 bit The problem with sending UTF-16 is that clients then need to consume UTF-16 which they probably don't by default. Ruby, for example, does not. There will probably come a time with UTF-16 is the right choice. I don't think it is today. Let's try to get out of the ASCII mud. :) |
I'm not really well versed on encodings, so I have to trust your judgement on that. I just would hate to use utf-8 if we knew it would cause problems for east-asian/middle eastern users, but if those character sets can be represented in utf-8 then it sounds like we should proceed with that. |
@@ -1,3 +1,7 @@ | |||
#if ! __has_feature(objc_arc) | |||
#warning This file must be compiled with ARC. Use -fobjc-arc flag (or convert project to ARC). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't miss having to write that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrate project to ARC so all new files are ARC by default #266
Pull requests welcome. :)
Motivation
Some characters in an element's text/label show up as "?" UITest #879
Also set the charset to UTF-8.
@JonStoneman I think the only way to test this in UITest is to build a new CalabashBinding. Chris or I can show you how to generate the binding.
TODO
ATTN: @sapieneptus We should check the response header in DeviceAgent.