-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model_read_lib visitAggregation is incorrect. #78
Comments
Setting visitAggregation = "day" now suddenly seems to work in the script combined.R without me changing anything else. The values for the # of ML 'hits' per morning appears reasonable. If someone else could confirm, I think we can close this issue? @matth79 The bad news is that simply changing the aggregation didn't seem to make model fit any better (MCMC chain convergence fails the Rhat < 1.1 rule-of-thumb for most parameters monitored) so we still have our work cut out for us in terms of model specification and fit. Some things to check off the top of my head (jotting down here before starting a new issue):
|
@mschulist Can you confirm this works as @mkclapp says if so this issue and a referring issue #61 can be closed. |
I reran the script and it does work without errors, but I cannot find the object |
Hi @mschulist, data <- readCombined( Feel free to add and push if you have an open branch for this issue! |
|
Setting aggregation to day does not do the right thing (per report in 6/29 meeting).
This issue tracks manual verification of each allowed setting and fixing as necessary.
The text was updated successfully, but these errors were encountered: