Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle WIP: poc L10n #331

Closed
wants to merge 12 commits into from
Closed

Restyle WIP: poc L10n #331

wants to merge 12 commits into from

Conversation

restyled-io[bot]
Copy link

@restyled-io restyled-io bot commented Oct 18, 2021

A duplicate of #306 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/calcitem/Sanmill.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

Leptopoda and others added 12 commits October 13, 2021 09:44
We will pre generate the asset paths.
This should lead to less errors in there.
update flutter-init.sh
- removed `shared/common/`
- implemented new data models for the settings
- implemented a new `LocalDatabaseService`

Why:
The new code will allow use to better utilize flutter's ractivenes. `HiveDB` (our new database backend) will give us `ValueListenable`, `Streams` and real time storage access. The sriliazation for the models is  generated by `build_runner` and even the old seriliazation for the storage migration is generated (json_serializable).

TODO:
- implement reactivenes. We currently don't utilize this functionality to it's full potential (`Consumer`) :)
- implement migration. The migration service for the old database service isn't there yet.
- make new storage reactive
- add Database Migrator

change how the developerMode reacts
Restyled by shellharden

Restyled by shfmt

Restyled by whitespace
@restyled-io restyled-io bot closed this Oct 18, 2021
@restyled-io restyled-io bot deleted the restyled/pull-306 branch October 18, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants