Hey there, @andy-vdg! I'm a bot here to help you with any issues, questions, or contributions. Let's work together to solve this bug!

To resolve the issue of email addresses with an apostrophe not being accepted, you need to update the email validation regex to include apostrophes. Here's how you can do it:

1. Update the email validation regex in the backend:

   Modify the z.string().email() validation to use a custom regex pattern that includes the apostrophe character. Here is an example of how you can update the code:

   import { withValidation } from "next-validations";
   import { z } from "zod";
   
   import { baseApiParams } from "./baseApiParams";
   
   // Custom email regex pattern to include apostrophe
   const emailRegex = /^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/;
   
   export const schemaQueryAttendeeEmail = baseApiParams.extend({
     attendeeEmail: z.string().regex(emailRegex, { message: "Invalid email address" }),
   });
   
   export const schemaQuerySingleOrMultipleAttendeeEmails = z.object({
     attendeeEmail: z.union([z.string().regex(emailRegex, { message: "Invalid email address" }), z.array(z.string().regex(emailRegex, { message: "Invalid email address" }))]).optional(),
   });
   
   export const withValidQueryAttendeeEmail = withValidation({
     schema: schemaQueryAttendeeEmail,
     type: "Zod",
     mode: "query",
   });

2. Update other parts of the codebase for consistency:

   Ensure that other parts of the codebase that perform email validation are also updated. This includes functions like checkInputEmailIsValid, createNewUsersConnectToOrgIfExists, and various email verification functions. You can find these in files such as inviteMemberUtils.ts, verifyEmail.ts, queryUserEmail.ts, and queryAttendeeEmail.ts ^[1][2][3][4].

3. Update frontend components:

   The SecondaryEmailModal component in apps/web/components/settings/SecondaryEmailModal.tsx also performs email validation. Update the validation to use the new regex pattern:

   const formMethods = useForm<FormValues>({
     resolver: zodResolver(
       z.object({
         email: z.string().regex(emailRegex), // Replace with your new regex
       })
     ),
   });

4. Update automated tests:

   Ensure that the automated tests for email validation include cases with apostrophes. Update the test cases in inviteMemberUtils.test.ts:

   describe("checkInputEmailIsValid", () => {
       it("should throw a TRPCError with code BAD_REQUEST if the email is invalid", () => {
           const invalidEmail = "invalid-email";
           expect(() => checkInputEmailIsValid(invalidEmail)).toThrow(TRPCError);
           expect(() => checkInputEmailIsValid(invalidEmail)).toThrowError(
               "Invite failed because invalid-email is not a valid email address"
           );
       });
   
       it("should not throw an error if the email is valid", () => {
           const validEmail = "[email protected]";
           const validEmailWithApostrophe = "john.o'[email protected]";
           expect(() => checkInputEmailIsValid(validEmail)).not.toThrow();
           expect(() => checkInputEmailIsValid(validEmailWithApostrophe)).not.toThrow();
       });
   });

By making these updates, you will ensure that email addresses with apostrophes are accepted across the entire application.

To continue talking to Dosu, mention @dosu.

@PeerRich
Do we need to allow apostrophes in email validation for this page only, or should this change be applied across the entire application? While allowing apostrophes would improve compatibility with some email addresses.

@PeerRich Do we need to allow apostrophes in email validation for this page only, or should this change be applied across the entire application? While allowing apostrophes would improve compatibility with some email addresses.

You should be able to book someone and sign up for an account with an email with an apostrophe.

ive never seen apostrophes in an email. didnt know that was a valid schema. i dont mind allowing it

we should be allowing it everywhere

ive never seen apostrophes in an email. didnt know that was a valid schema. i dont mind allowing it

Me either, and I've seen a lot of Irish email addresses 😅 Gmail don't allow it. Marking as Low priority.

Thanks for clarifying! I'm updating the email validations using regex, so an user with an apostrophe in their email, can able to sign up or book appointments.

@ciaranha I hadn't come across it either before - but as luck would have it - this week I had two separate people from two different continents (UK and NZ) try and book in with a ' in their email address.
Turns out even though Gmail doesn't allow it - Microsoft does.
Thanks @RajdeepDs much appreciated.

@ciaranha I hadn't come across it either before - but as luck would have it - this week I had two separate people from two different continents (UK and NZ) try and book in with a ' in their email address. Turns out even though Gmail doesn't allow it - Microsoft does. Thanks @RajdeepDs much appreciated.

Ah great to know, thanks for sharing @andy-vdg 🙏 Bumping back to medium priority 😅 Looks like we'll have a fix for this out pretty quickly!

Hi Guys!
I have just tried attempting this one, just take a look guys and see if this looks good ✨
attempt /#16348

Thank You,
AR. Nath