fix: email-address with apostrophe not accepted #15535
Conversation
|
@RajdeepDs is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
bot
added
booking-page
dosubot
bot
added
authentication
Graphite Automations"Add community label" took an action on this PR • (06/22/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/22/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (06/25/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Twenty-two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
Hi @keithwillcode, |
|
This one seems to be fixed in later zod versions. I think upgrading zod should fix it everywhere? It seems we haven't updated in a while. So, it is due anyway. |
There was a problem hiding this comment.
@RajdeepDs Thanks for the PR 🙏
Zod latest version should have this fixed already.
But I am also thinking that it might make sense to have this flexibility of having email validation changed by changing the RegExp. It can allow us to fix email validation everywhere without heavily relying on zod's updates.
cc @keithwillcode @zomars what do you guys think ?
| @@ -14,7 +15,7 @@ export const schemaAttendeeBaseBodyParams = Attendee.pick({ | |||
| const schemaAttendeeCreateParams = z | |||
| .object({ | |||
| bookingId: z.number().int(), | |||
| email: z.string().email(), | |||
| email: z.string().regex(emailRegex), | |||
There was a problem hiding this comment.
We should be more declarative here like defining an emailSchema somewhere and importing that directly.
There was a problem hiding this comment.
Sure, I've made changes to the code by creating a new file emailSchema.ts that defines the emailSchema using the Reg Exp. This schema is now imported and used in the places where email validation is needed.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)