Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Zoom integration doesn't follow the zoom app settings for auto-record #15478

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sbsangu
Copy link
Contributor

@sbsangu sbsangu commented Jun 18, 2024

What does this PR do?

This PR addresses the issue identified in [CAL-3943] where meetings generated via cal.com to our team's Zoom account do not auto-record despite the Zoom app settings being configured to enable auto-recording. This change ensures that meetings created through cal.com adhere to the Zoom app settings for auto-recording.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • N/A-I have added a Docs issue here if this PR makes changes that would require a documentation change
  • N/A-I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Checklist

  • I have read the contributing guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked if my changes generate no new warnings

Copy link

vercel bot commented Jun 18, 2024

@sbsangu is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 18, 2024
@graphite-app graphite-app bot requested a review from a team June 18, 2024 13:38
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix: Zoom integration doesn't follow the zoom app settings for auto-record". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar 🐛 bug Something isn't working labels Jun 18, 2024
@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Jun 18, 2024
@sbsangu sbsangu changed the title Fix: Zoom integration doesn't follow the zoom app settings for auto-record fix: Zoom integration doesn't follow the zoom app settings for auto-record Jun 18, 2024
Copy link

graphite-app bot commented Jun 18, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/18/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job - lets fix eslint errors + can we try add the default password into the meeting as i think we can do this now as we have the settings for the users new events

@keithwillcode keithwillcode added this to the v4.4 milestone Jun 19, 2024
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Jun 21, 2024
@sbsangu sbsangu requested a review from sean-brydon June 21, 2024 14:43
@sbsangu
Copy link
Contributor Author

sbsangu commented Jun 26, 2024

@sean-brydon does this now resolve the issue #15474 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3943] Zoom integration doesn't follow the zoom app settings for auto-record
4 participants