feat: Add URL-type input in booking question field #15481
Conversation
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
booking-page
Graphite Automations"Add community label" took an action on this PR • (06/18/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
keithwillcode
added
the
community-interns
| @@ -120,6 +120,7 @@ function preprocess<T extends z.ZodType>({ | |||
| return isValidPhoneNumber(val); | |||
| }); | |||
| // Tag the message with the input name so that the message can be shown at appropriate place | |||
| const urlSchema = z.string().url(); | |||
There was a problem hiding this comment.
This line came in b/w comment on line 122 and related code.
| if (bookingField.type === "url") { | ||
| // URL schema to validate if the input is a valid URL | ||
| if (!urlSchema.safeParse(value).success) { | ||
| ctx.addIssue({ | ||
| code: z.ZodIssueCode.custom, | ||
| message: m("url_validation_error"), | ||
| }); | ||
| } | ||
| continue; | ||
| } |
There was a problem hiding this comment.
superRefine for url type field in the same way we have done for 'name' type field.
We want to avoid increase this file's size and make all refinements testable.
After that it would make sense to add a simple test for url type field schema validation
| url: { | ||
| propsType: propsTypes.url, | ||
| factory: (props) => { | ||
| if (!props) { |
There was a problem hiding this comment.
Is there a case where props could be undefined?
It feels wrong to return a different element from the same component conditionally. Like if no props are provided return <div> otherwise <TextWidget>
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist