Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add proton calendar #15501

Closed
wants to merge 2 commits into from
Closed

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Jun 19, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • N/A I have added a Docs issue here if this PR makes changes that would require a documentation change
  • N/A I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 19, 2024
@graphite-app graphite-app bot requested a review from a team June 19, 2024 19:30
Copy link

vercel bot commented Jun 19, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added api area: API, enterprise API, access token, OAuth calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar Medium priority Created by Linear-GitHub Sync labels Jun 19, 2024
@dosubot dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar ✨ feature New feature or request labels Jun 19, 2024
@dosubot dosubot bot added this to the v4.4 milestone Jun 19, 2024
@anikdhabal
Copy link
Contributor Author

As of now, Proton Calendar does not have any public API, so in v1, let's make it dependent on Google Calendar. In v2, if we obtain the public API, then we can integrate it properly with OAuth.

@anikdhabal anikdhabal changed the title feat: proton calendar app feat: Add proton calendar Jun 19, 2024
Copy link

graphite-app bot commented Jun 19, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/19/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Ryukemeister
Copy link
Contributor

As of now, Proton Calendar does not have any public API, so in v1, let's make it dependent on Google Calendar. In v2, if we obtain the public API, then we can integrate it properly with OAuth.

@emrysal @ThyMinimalDev what do you folks think about this approach for v1?

@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Jun 27, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jul 12, 2024
@dosubot dosubot bot modified the milestones: v4.4, v4.5 Jul 17, 2024
@github-actions github-actions bot removed the Stale label Jul 18, 2024
@ThyMinimalDev
Copy link
Contributor

not sure to understand the goal of this if Proton Calendar does not have any public API ?

@anikdhabal
Copy link
Contributor Author

not sure to understand the goal of this if Proton Calendar does not have any public API ?

Hey most third-party calendars offer a “subscribe to calendar” feature that allows to enter the shared calendar’s URL. Subscribing to a calendar in this way syncs the calendar to shared Proton Mail calendar.

In Google Calendar (web app), for example, go to Settings → Add calendar → From URL. Paste the shared calendar’s URL into the From URL field and click Add calendar.

And as you can see this calendar also dependent to google calendar. We have calendar apps like: vimcal, ammie etc. that is similar to this

@emrysal
Copy link
Contributor

emrysal commented Jul 24, 2024

Although this works from a Calendar POV, Proton Calendar users are all about privacy and data ownership. Having this calendar work through Google makes little sense in my opinion because Proton users will never agree to this.

IMO this is not the way to implement - let's wait until Proton has a native way of calendar integration such as CalDav or at least some way native to us so we don't have to rely on Google for these users.

@anikdhabal
Copy link
Contributor Author

Although this works from a Calendar POV, Proton Calendar users are all about privacy and data ownership. Having this calendar work through Google makes little sense in my opinion because Proton users will never agree to this.

IMO this is not the way to implement - let's wait until Proton has a native way of calendar integration such as CalDav or at least some way native to us so we don't have to rely on Google for these users.

Yeah, this makes sense. Make this PR a draft until we have some implementation details

@anikdhabal anikdhabal marked this pull request as draft July 24, 2024 17:50
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Aug 8, 2024
@Amit91848
Copy link
Contributor

Since there is no definite timeline as to when things would progress, it's better to close this for now.

@Amit91848 Amit91848 closed this Sep 7, 2024
@dosubot dosubot bot modified the milestones: v4.5, v4.6 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3640] App: Proton Calendar
6 participants