-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: meeting link is not updated and broken ui in edit location dialog #15503
Conversation
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add community label" took an action on this PR • (06/20/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Anik. I request changes because of comment below.
packages/trpc/server/routers/viewer/bookings/editLocation.handler.ts
Outdated
Show resolved
Hide resolved
This PR is being marked as stale due to inactivity. |
@anikdhabal any update on this PR? |
This PR is being marked as stale due to inactivity. |
Actually, we faced this error in dev mode if the Cal video API key is null. In production, I’ve tested it and it works fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text area min and max characters text > Create a new event E2E test is failing because it's not able to find any slot at the end of the month. so we can fix it by going to next month if there is no available slots.
Thank goodness this is finally fixed! Much appreciated. |
@Udit-takkar @PeerRich this PR shouldn't have been merged yet. Will revert. Unless I'm missing more context if we have a location that doesn't start with "https" It will wipe out all existing booking metadata. |
What does this PR do?
before:-
Now:-
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist