Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: meeting link is not updated and broken ui in edit location dialog #15503

Merged
merged 9 commits into from
Jul 31, 2024

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Jun 20, 2024

What does this PR do?

before:-
Screenshot 2024-06-20 091049

Now:-
Screenshot 2024-06-20 090909

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 20, 2024
@graphite-app graphite-app bot requested a review from a team June 20, 2024 03:26
Copy link

vercel bot commented Jun 20, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jun 20, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Jun 20, 2024
Copy link

graphite-app bot commented Jun 20, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal changed the title fix: meeting link is not updated fix: meeting link is not updated and broken ui in edit location dialog Jun 20, 2024
@keithwillcode keithwillcode added this to the v4.4 milestone Jun 20, 2024
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Anik. I request changes because of comment below.

@supalarry
Copy link
Contributor

What I also found is that if one changes location of booking to cal video:

Screenshot 2024-06-21 at 15 02 19

saves and refreshes page and checks location, its still the previous one:
Screenshot 2024-06-21 at 15 02 33

@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Jun 27, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jul 12, 2024
@Udit-takkar Udit-takkar removed the Stale label Jul 12, 2024
@Udit-takkar Udit-takkar marked this pull request as draft July 12, 2024 10:55
@Udit-takkar
Copy link
Contributor

@anikdhabal any update on this PR?

Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jul 27, 2024
@anikdhabal
Copy link
Contributor Author

anikdhabal commented Jul 27, 2024

What I also found is that if one changes location of booking to cal video:

Actually, we faced this error in dev mode if the Cal video API key is null. In production, I’ve tested it and it works fine
Thanks @supalarry for the reviews.

@anikdhabal anikdhabal marked this pull request as ready for review July 27, 2024 07:00
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Jul 27, 2024
@github-actions github-actions bot removed the Stale label Jul 28, 2024
@anikdhabal anikdhabal requested review from supalarry and removed request for supalarry July 30, 2024 07:54
PeerRich
PeerRich previously approved these changes Jul 31, 2024
@PeerRich PeerRich enabled auto-merge (squash) July 31, 2024 12:53
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text area min and max characters text > Create a new event E2E test is failing because it's not able to find any slot at the end of the month. so we can fix it by going to next month if there is no available slots.

@PeerRich PeerRich merged commit 9ffa4b8 into calcom:main Jul 31, 2024
27 of 35 checks passed
@RayBB
Copy link

RayBB commented Jul 31, 2024

Thank goodness this is finally fixed! Much appreciated.

@zomars
Copy link
Member

zomars commented Jul 31, 2024

@Udit-takkar @PeerRich this PR shouldn't have been merged yet. Will revert. Unless I'm missing more context if we have a location that doesn't start with "https" It will wipe out all existing booking metadata.

image

@anikdhabal anikdhabal deleted the issue#15497 branch July 31, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs Medium priority Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Very annoying) Guest doesn't see updated meeting link on booking page
7 participants