Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #9523 limited scroll range on mobile device #15505

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stefanmuljadi
Copy link

@stefanmuljadi stefanmuljadi commented Jun 20, 2024

What does this PR do?

As per the suggestion in #9523, overflow-y-auto and scroll-auto are removed to prevent having a double scroll wheel that causes the users to be unable to scroll through the page as expected unless they begin to click into the form and fill out payment info.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

Copy link

vercel bot commented Jun 20, 2024

@stefanmuljadi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 20, 2024
@graphite-app graphite-app bot requested review from a team June 20, 2024 09:58
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix/issue 9523". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync Stale ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Jun 20, 2024
@dosubot dosubot bot added the billing area: billing, stripe, payments, paypal, get paid label Jun 20, 2024
Copy link

graphite-app bot commented Jun 20, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (06/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@stefanmuljadi stefanmuljadi changed the title Fix/issue 9523 fix: issue #9523 limited scroll range on mobile device Jun 20, 2024
@keithwillcode keithwillcode modified the milestones: v4.4, Community Only Jun 20, 2024
@github-actions github-actions bot removed the Stale label Jun 21, 2024
@Ryukemeister
Copy link
Contributor

@stefanmuljadi it looks like you've pushed the changes for the yarn.lock file. We generally update the yarn.lock while updating or deleting packages and it doesn't seem like we're doing that here, can you revert the yarn.lock file changes?

@github-actions github-actions bot added the Stale label Jun 25, 2024
@hariombalhara
Copy link
Member

@stefanmuljadi Could you please record a before and after loom/video for both embedded and non-embedded booker

@github-actions github-actions bot removed the Stale label Jun 26, 2024
@github-actions github-actions bot added the Stale label Jun 27, 2024
@github-actions github-actions bot removed the Stale label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
billing area: billing, stripe, payments, paypal, get paid 🐛 bug Something isn't working community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripe App - overflow-y-auto limits scroll range on mobile device
4 participants