fix: Timezone in Email Embed not working #15525 #15537
Conversation
|
@acharyayush is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
dosubot
bot
added
embed
Graphite Automations"Add community label" took an action on this PR • (06/22/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/22/24)1 reviewer was added to this PR based on Keith Williams's automation. |
| @@ -299,7 +299,7 @@ const EmailEmbed = ({ | |||
| <Collapsible open> | |||
| <CollapsibleContent> | |||
| <div className="text-default mb-[9px] text-sm">{t("timezone")}</div> | |||
| <TimezoneSelect id="timezone" value={timezone} isDisabled /> | |||
There was a problem hiding this comment.
@acharyayush how about toggling the value of the prop isDisabled?
<TimezoneSelect id="timezone" value={timezone} isDisabled={false} />
Toggled the value of isDisabled to false instead of removing
| @@ -64,6 +66,7 @@ export function TimezoneSelectComponent({ | |||
| ...(data ? addCitiesToDropdown(data) : {}), | |||
| ...addCitiesToDropdown(cities), | |||
| }} | |||
| onChange={({ value }) => setTimezone(value)} | |||
There was a problem hiding this comment.
Aren't onChange and onInputChange handlers one and the same? The issue was that the timezone selector was disabled because of previously setting the isDisabled prop to true right? So is this really needed now?
| @@ -299,7 +299,7 @@ const EmailEmbed = ({ | |||
| <Collapsible open> | |||
| <CollapsibleContent> | |||
| <div className="text-default mb-[9px] text-sm">{t("timezone")}</div> | |||
| <TimezoneSelect id="timezone" value={timezone} isDisabled /> | |||
| <TimezoneSelect id="timezone" value={timezone} isDisabled={false} /> | |||
There was a problem hiding this comment.
@hariombalhara was this disabled on purpose?
There was a problem hiding this comment.
@Pradumn27 worked on this feature. I believe there has to be a reason. It isn't accidental.
What does this PR do?
Timezone selection in email embed page was disabled. I enabled it by updating the timezone of localstorage when user selects another timezone
##Before
https://www.loom.com/share/c5a5e587307241ecb76fd349ca33551b
##After
https://www.loom.com/share/a017ffb10f5641ad9d48130e3c964883
Mandatory Tasks (DO NOT REMOVE)