fix: icon visibility and add up and down icons #15543

Sahillather002 · 2024-06-23T03:01:24Z

What does this PR do?

Fixed the dropdown icon visibility and added the icon which changes on state of dropdown opens or not.

Fixes In Workflows page dropdown icon is not properly visible in the time unit input and request for addition of up and down icons #15542(GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected)
I have added a Docs issue here if this PR makes changes that would require a documentation change
I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

vercel · 2024-06-23T03:01:30Z

@Sahillather002 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2024-06-23T03:01:30Z

All committers have signed the CLA.

github-actions · 2024-06-23T03:01:37Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fixed the icons visibility and added up and down icon". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

graphite-app · 2024-06-23T03:05:12Z

Graphite Automations

"Add community label" took an action on this PR • (06/23/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Ryukemeister

Other than the one small change looks great, nice job!

Ryukemeister · 2024-06-23T04:31:22Z

packages/features/ee/workflows/components/TimeTimeUnitInput.tsx

                    {timeUnit ? t(`${timeUnit.toLowerCase()}_timeUnit`) : "undefined"}{" "}
                  </div>
-                  <div className="w-1/4 pt-1">


@Sahillather002 you can keep the width here as w=1/4, no need to change it to 2/5

@Ryukemeister i did it because icon was hiding to that width so gives larger width, or i can reduce the size of icon

I checked using w=1/4 and it was looking good for me.

github-actions · 2024-06-23T23:06:33Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/[user]/[type]`	`416.73 KB`	644.46 KB	184.13% (🟡 +0.17%)
`/[user]/[type]/embed`	`416.74 KB`	644.46 KB	184.13% (🟡 +0.17%)
`/apps/[slug]/[...pages]`	`593.43 KB`	821.15 KB	234.61% (🟡 +0.23%)
`/auth/saml-idp`	`12.22 KB`	239.95 KB	68.56% (🟢 -20.80%)
`/d/[link]/[slug]`	`416.54 KB`	644.26 KB	184.07% (🟡 +0.17%)
`/event-types`	`566.45 KB`	794.18 KB	226.91% (🟡 +0.31%)
`/event-types/[type]`	`442.11 KB`	669.83 KB	191.38% (🟡 +0.17%)
`/org/[orgSlug]/[user]/[type]`	`416.94 KB`	644.66 KB	184.19% (🟡 +0.16%)
`/org/[orgSlug]/[user]/[type]/embed`	`416.96 KB`	644.68 KB	184.19% (🟡 +0.17%)
`/org/[orgSlug]/instant-meeting/team/[slug]/[type]`	`416.55 KB`	644.28 KB	184.08% (🟡 +0.16%)
`/org/[orgSlug]/team/[slug]/[type]`	`416.75 KB`	644.47 KB	184.14% (🟡 +0.16%)
`/settings/admin/lockedSMS/UsersTable`	`79.97 KB`	307.69 KB	87.91% (🟢 -0.14%)
`/settings/admin/lockedSMS/lockedSMSView`	`119.45 KB`	347.17 KB	99.19% (🟢 -0.17%)
`/settings/admin/oAuth/oAuthView`	`95.48 KB`	323.21 KB	92.34% (🟢 -0.17%)
`/settings/organizations/[id]/about`	`159.66 KB`	387.38 KB	110.68% (🟡 +0.47%)
`/settings/organizations/[id]/add-teams`	`159.65 KB`	387.37 KB	110.68% (🟡 +0.47%)
`/settings/organizations/new`	`159.66 KB`	387.38 KB	110.68% (🟡 +0.47%)
`/settings/platform/new`	`120.7 KB`	348.43 KB	99.55% (🟡 +0.52%)
`/team/[slug]/[type]`	`416.72 KB`	644.44 KB	184.13% (🟡 +0.16%)
`/team/[slug]/[type]/embed`	`416.75 KB`	644.47 KB	184.14% (🟡 +0.16%)
`/video/[uid]`	`291.21 KB`	518.93 KB	148.27% (🟢 -0.17%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

emrysal · 2024-06-24T22:58:37Z

Drafting as making a little style update.

emrysal · 2024-06-25T01:20:50Z

Hey @Sahillather002 - I've updated the code to incorporate @Ryukemeister's observations and did a minor re-organisation in order to optimise the component & make it less complex. With these changes the re-render is isolated to the dropdown and certain input is cached (like i18n) whenever the dropdown is opened.

fixed the icons visibility and added up and down icon

4c56467

graphite-app bot added the community Created by Linear-GitHub Sync label Jun 23, 2024

graphite-app bot requested a review from a team June 23, 2024 03:01

github-actions bot added workflows area: workflows, automations 🐛 bug Something isn't working labels Jun 23, 2024

dosubot bot added the ui area: UI, frontend, button, form, input label Jun 23, 2024

Ryukemeister changed the title ~~fixed the icons visibility and added up and down icon~~ fix: icon visibility and add up and down icons Jun 23, 2024

Ryukemeister reviewed Jun 23, 2024

View reviewed changes

Merge branch 'main' into fix/15542-dropdown-icons

8591954

keithwillcode added the ready-for-e2e label Jun 23, 2024

keithwillcode and others added 2 commits June 24, 2024 18:34

Merge branch 'main' into fix/15542-dropdown-icons

0540f9f

wip: TimeUnitAddonSuffix

fd5c669

emrysal marked this pull request as draft June 24, 2024 22:58

emrysal marked this pull request as ready for review June 25, 2024 00:08

chore: Quick pass for rerender-optimisation

e9cd90a

emrysal force-pushed the fix/15542-dropdown-icons branch from 8ce15e9 to e9cd90a Compare June 25, 2024 00:16

emrysal and others added 2 commits June 25, 2024 13:35

Merge branch 'main' into fix/15542-dropdown-icons

a376a1d

Merge branch 'main' into fix/15542-dropdown-icons

37e0c7c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: icon visibility and add up and down icons #15543

fix: icon visibility and add up and down icons #15543

Sahillather002 commented Jun 23, 2024 •

edited

Loading

vercel bot commented Jun 23, 2024

CLAassistant commented Jun 23, 2024 •

edited

Loading

github-actions bot commented Jun 23, 2024 •

edited

Loading

graphite-app bot commented Jun 23, 2024

Ryukemeister left a comment •

edited

Loading

Ryukemeister Jun 23, 2024 •

edited

Loading

Sahillather002 Jun 23, 2024

Ryukemeister Jun 24, 2024

github-actions bot commented Jun 23, 2024 •

edited

Loading

emrysal commented Jun 24, 2024

emrysal commented Jun 25, 2024

fix: icon visibility and add up and down icons #15543

Are you sure you want to change the base?

fix: icon visibility and add up and down icons #15543

Conversation

Sahillather002 commented Jun 23, 2024 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

vercel bot commented Jun 23, 2024

CLAassistant commented Jun 23, 2024 • edited Loading

github-actions bot commented Jun 23, 2024 • edited Loading

graphite-app bot commented Jun 23, 2024

Graphite Automations

Ryukemeister left a comment • edited Loading

Choose a reason for hiding this comment

Ryukemeister Jun 23, 2024 • edited Loading

Choose a reason for hiding this comment

Sahillather002 Jun 23, 2024

Choose a reason for hiding this comment

Ryukemeister Jun 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 23, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

Twenty-one Pages Changed Size

emrysal commented Jun 24, 2024

emrysal commented Jun 25, 2024

Sahillather002 commented Jun 23, 2024 •

edited

Loading

CLAassistant commented Jun 23, 2024 •

edited

Loading

github-actions bot commented Jun 23, 2024 •

edited

Loading

Ryukemeister left a comment •

edited

Loading

Ryukemeister Jun 23, 2024 •

edited

Loading

github-actions bot commented Jun 23, 2024 •

edited

Loading