Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: org team app install #15550

Open
wants to merge 11 commits into
base: app-install-flow-followup
Choose a base branch
from

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Jun 24, 2024

What does this PR do?

https://www.loom.com/share/427bd864b1344bac92c3d650057ff9d8?sid=e994c6b1-319a-4cad-bef7-7e912d6be40a

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • --(N/A)--I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • checkout the loom

Copy link

linear bot commented Jun 24, 2024

@graphite-app graphite-app bot requested a review from a team June 24, 2024 09:50
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Feat" found in pull request title "Feat: org team app install". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jun 24, 2024
@dosubot dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar teams area: teams, round robin, collective, managed event-types ✨ feature New feature or request labels Jun 24, 2024
Copy link

graphite-app bot commented Jun 24, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@@ -413,51 +456,101 @@ const getAppBySlug = async (appSlug: string) => {
return app;
};

const getEventTypes = async (userId: number, teamId?: number) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grouping all the event-types of a team/user -- so that its easier to show them in groups, Previously, we could only install the app for a single user on a single team, but now organizations may have many teams. Separating events by team will make it more manageable.
Screenshot 2024-06-24 at 3 25 54 PM

@keithwillcode keithwillcode changed the title Feat: org team app install feat: org team app install Jun 24, 2024
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 4:48pm
cal ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 4:48pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 4:48pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar consumer core area: core, team members only ✨ feature New feature or request teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants