Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Round Robin Weights #15558

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

feat: Round Robin Weights #15558

wants to merge 38 commits into from

Conversation

CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented Jun 25, 2024

What does this PR do?

Adds weights to round robin alogirthm. When weights are enabled each host has 100% as the default weight. That means that ideally, all hosts end up with the same amount of bookings. If weights are enabled, priorities are only taken into account when more than one host is selected by the getUsersBasedOnWeights function.

Weights enabled:
Screenshot 2024-06-25 at 4 30 13 PM

Weights disabled:
Screenshot 2024-06-25 at 4 30 29 PM

Set weight:
Screenshot 2024-06-25 at 4 31 00 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs Add Round Robin weights docs#101
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Create RR event type and enable weights
  • test different weights and priority settings
  • test adding new hosts when bookings already exists and see if weightAdjustment was correctly saved

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jun 25, 2024
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 6:10am
cal ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 6:10am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 6:10am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ✨ feature New feature or request High priority Created by Linear-GitHub Sync ❗️ migrations contains migration files teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3869] Round Robin Weights
2 participants