Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added credentials line to enableCors in app.ts #15562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Neon-20
Copy link
Contributor

@Neon-20 Neon-20 commented Jun 25, 2024

Adding credentials

  • By setting credentials: true in the CORS configuration, we're telling the browser that the server is allowed to receive credentials in the request.
  • This allows the browser to include credentials in the request, and the server can then authenticate the request accordingly.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

Copy link

vercel bot commented Jun 25, 2024

@Neon-20 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 25, 2024
@graphite-app graphite-app bot requested a review from a team June 25, 2024 07:58
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 💻 refactor labels Jun 25, 2024
Copy link

graphite-app bot commented Jun 25, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/25/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode requested a review from a team June 25, 2024 18:20
@keithwillcode keithwillcode added this to the v4.4 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth community Created by Linear-GitHub Sync 💻 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants