feat: RECORDING_TRANSCRIPTION_GENERATED webhook #15589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
High priority
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
github-actions
bot
added
High priority
Udit-takkar
changed the title
Udit-takkar
commented
Jun 30, 2024
Comment on lines
+53
to
+102
| const BATCH_PROCESSOR_JOB_FINSISHED_PAYLOAD = { | ||
| version: "1.1.0", | ||
| type: "batch-processor.job-finished", | ||
| id: "77b1cb9e-cd79-43cd-bad6-3ccaccba26be", | ||
| payload: { | ||
| id: "77b1cb9e-cd79-43cd-bad6-3ccaccba26be", | ||
| status: "finished", | ||
| input: { | ||
| sourceType: "recordingId", | ||
| recordingId: "eb9e84de-783e-4e14-875d-94700ee4b976", | ||
| }, | ||
| output: { | ||
| transcription: [ | ||
| { | ||
| format: "json", | ||
| s3Config: { | ||
| key: "transcript.json", | ||
| bucket: "daily-bucket", | ||
| region: "us-west-2", | ||
| }, | ||
| }, | ||
| { | ||
| format: "srt", | ||
| s3Config: { | ||
| key: "transcript.srt", | ||
| bucket: "daily-bucket", | ||
| region: "us-west-2", | ||
| }, | ||
| }, | ||
| { | ||
| format: "txt", | ||
| s3Config: { | ||
| key: "transcript.txt", | ||
| bucket: "daily-bucket", | ||
| region: "us-west-2", | ||
| }, | ||
| }, | ||
| { | ||
| format: "vtt", | ||
| s3Config: { | ||
| key: "transcript.vtt", | ||
| bucket: "daily-bucket", | ||
| region: "us-west-2", | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| event_ts: 1717688213.803, | ||
| }; |
There was a problem hiding this comment.
payload received by endpoint /recorded-daily-video
Udit-takkar
commented
Jun 30, 2024
|
|
||
| const log = logger.getSubLogger({ prefix: ["daily-video-webhook-handler"] }); | ||
|
|
||
| const commonSchema = z |
There was a problem hiding this comment.
zod schemas moved to other file
Udit-takkar
commented
Jun 30, 2024
Comment on lines
-266
to
-268
| if (!bookingReference || !bookingReference.bookingId) { | ||
| return res.status(200).send({ message: "Booking reference not found" }); | ||
| } |
There was a problem hiding this comment.
added these checks inside getBookingReference
Udit-takkar
commented
Jun 30, 2024
| @@ -348,11 +166,57 @@ async function handler(req: NextApiRequest, res: NextApiResponse) { | |||
| const evt = await getCalendarEvent(booking); | |||
| await sendDailyVideoTranscriptEmails(evt, transcripts); | |||
|
|
|||
| return res.status(200).json({ message: "Success" }); | |||
| } else if (req.body?.type === "batch-processor.job-finished") { | |||
There was a problem hiding this comment.
This is the new payload type that i added
Udit-takkar
commented
Jun 30, 2024
Comment on lines
+180
to
+184
| const roomName = await getRoomNameFromRecordingId(input.recordingId); | ||
|
|
||
| const bookingReference = await getBookingReference(roomName); | ||
|
|
||
| const booking = await getBooking(bookingReference.bookingId as number); |
There was a problem hiding this comment.
As the payload didn't have roomName or bookingId. we first get the roomName from recordingId and then get bookingId from bookingReference
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/30/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TODO:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
It'll be a little difficult to test this locally
Create a event type and create a new trigger TRANSCRIPTION_GENERATED
Now Create a booking with that event type.
comment L185 and in L187 replace bookingReference.bookingId with booking ID that you created above (in file apps/web/pages/api/recorded-daily-video.ts)
and comment line const computed_signature = computeSignature(hmacSecret, req.body, req.headers["x-webhook-timestamp"]);
Now make a POST request to /api/recorded-daily-video with this payload https://github.com/calcom/cal.com/pull/15589/files#r1660164633