Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add max and min characters inputs for long text input for booking questions(Minor) #15596

Closed
wants to merge 8 commits into from

Conversation

rajeshj11
Copy link
Contributor

@rajeshj11 rajeshj11 commented Jun 27, 2024

/claim #15577

What does this PR do?

  1. added min characters and max characters input fields for long text.
  2. Handled the validation of the min and max for the long text input
  3. Internationalize logic is implemented but the values need to be changed.(TO DO)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Feat:Add max and min characters inputs for long text input for booking questions(Minor)". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the i18n area: i18n, translations label Jun 27, 2024
@dosubot dosubot bot added this to the Community Only milestone Jun 27, 2024
Copy link

vercel bot commented Jun 27, 2024

@rajeshj11 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

graphite-app bot commented Jun 27, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/27/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (06/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@rajeshj11 rajeshj11 changed the title Feat 15577 Feat 15577 Add max and min characters inputs fro long text input fro booking questions Jun 27, 2024
@rajeshj11 rajeshj11 changed the title Feat 15577 Add max and min characters inputs fro long text input fro booking questions Feat:Add max and min characters inputs fro long text input fro booking questions(Minor) Jun 27, 2024
@rajeshj11 rajeshj11 changed the title Feat:Add max and min characters inputs fro long text input fro booking questions(Minor) Feat:Add max and min characters inputs for long text input for booking questions(Minor) Jun 27, 2024
@anikdhabal anikdhabal changed the title Feat:Add max and min characters inputs for long text input for booking questions(Minor) feat: Add max and min characters inputs for long text input for booking questions(Minor) Jun 27, 2024
@PeerRich
Copy link
Member

can you remove all translations and only add it to /en/ ?

we translate outside of git

@rajeshj11
Copy link
Contributor Author

can you remove all translations and only add it to /en/ ?

we translate outside of git

updated please check

@hariombalhara
Copy link
Member

hariombalhara commented Jun 28, 2024

@rajeshj11 Thanks for the PR but I have to close it in favour of #15592 which was opened earlier and is already reviewed once and has some feedback addressed.

@dosubot dosubot bot modified the milestone: Community Only Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker 🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync ✨ feature New feature or request i18n area: i18n, translations Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3973] booking questions for long text: add min and max characters (both optionally)
5 participants