Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect booking seats full error on collective seated event #15602

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Jun 27, 2024

What does this PR do?

This issue occurs because the backend compares the total number of attendees (team members + booked seats) to the total number of seats per slot, instead of comparing the actual booked seats to the total number of seats per slot.

https://www.loom.com/share/ff752121048b4e18a1ad64026963347d?sid=6686b5a4-d39f-4019-8122-c27630ae66db

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Create a collective team seated event with a total of 3 seats.
  2. Assign 3 team members to attend the event.
  3. Book 1 seat for the event.
  4. Attempt to book an additional seat for the same slot.
  5. Notice the second booking is successful.

Copy link

vercel bot commented Jun 27, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 27, 2024
@graphite-app graphite-app bot requested a review from a team June 27, 2024 17:08
@github-actions github-actions bot added seats area: seats, guest meetings, multiple people teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Jun 27, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Jun 27, 2024
Copy link

graphite-app bot commented Jun 27, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/27/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kart1ka Could you also add unit tests for this bug fix?

@kart1ka
Copy link
Contributor Author

kart1ka commented Jun 30, 2024

@kart1ka Could you also add unit tests for this bug fix?

Hi @Udit-takkar

I have added the unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync seats area: seats, guest meetings, multiple people teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect All Seats Booked Error for Collective Team Seated Events
3 participants