-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CAL-3959 Disable Duplicate button in Readonly event type #15605
fix: CAL-3959 Disable Duplicate button in Readonly event type #15605
Conversation
@DiveshHariani is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add community label" took an action on this PR • (06/27/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/27/24)1 reviewer was added to this PR based on Keith Williams's automation. |
04a0528
to
d7df458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DiveshHariani, instead of disabling the button, could you remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
You need to add this condition at the bottom component as well for small screens. You missed it.
And pls update the e2e test.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Twenty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
/atteemp |
Thanks @anikdhabal. I will do these right away. |
…ll and large views
Hi, I updated the code to remove the duplicate button. Can you please provide some guidelines for E2E tests? I cannot see any, for now, on Contributing.md. Do I need to create a new test or change the existing test? |
Hey Divesh thanks for the work. But this pr #15511 is much earlier. Closing this |
What does this PR do?
Summary of Changes: Added condition to disable the duplicate button based on the readOnly value
Mandatory Tasks (DO NOT REMOVE)