Skip to content

fix: update booking location to meetingUrl on confirmation (Self-Hosted)#29553

Open
SparshGarg999 wants to merge 1 commit into
calcom:mainfrom
SparshGarg999:fix/18259-conferencing-location
Open

fix: update booking location to meetingUrl on confirmation (Self-Hosted)#29553
SparshGarg999 wants to merge 1 commit into
calcom:mainfrom
SparshGarg999:fix/18259-conferencing-location

Conversation

@SparshGarg999

Copy link
Copy Markdown

What does this PR do?

Fixes conferencing location displaying raw integration slugs (e.g. integrations:office365_video, integrations:discord_video) instead of the actual meeting URL in calendar events and ICS files for self-hosted instances.

Root Cause

When a booking requiring confirmation is approved, handleConfirmation.ts generates the actual meeting URL and stores it in metadata.videoCallUrl. However, the location field in the database was never updated - it remained as the raw integration slug set at booking creation time.

Calendar events / ICS files read from the location field, so attendees saw the slug instead of a clickable meeting link.

Fix

In handleConfirmation.ts, update the Prisma booking.update() call for both single and recurring bookings to also set location = meetingUrl whenever a meetingUrl is successfully generated upon confirmation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have self-reviewed the code
  • PR size is minimal (1 source file, 2 lines changed)
  • No new dependencies added

Closes #18259

When a booking requiring confirmation is approved, the integration slug
(e.g. integrations:office365_video, integrations:discord_video) was
stored as the booking location. After confirmation, the actual meeting
URL was generated and stored only in metadata.videoCallUrl, but the
location field was never updated.

This caused calendar events and ICS files to display the raw integration
slug instead of the actual conferencing link.

Fix: update the Prisma booking.update() call for both single and
recurring bookings to also set location = meetingUrl when a
meetingUrl is successfully generated on confirmation.

Fixes calcom#18259
@github-actions github-actions Bot added booking-page area: booking page, public booking page, booker Medium priority Created by Linear-GitHub Sync self-hosting Stale 🐛 bug Something isn't working labels Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Cal.diy, @SparshGarg999! Thanks for opening this pull request.

A few things to keep in mind:

  • This is Cal.diy, not Cal.com. Cal.diy is a community-driven, fully open-source fork of Cal.com licensed under MIT. Your changes here will be part of Cal.diy — they will not be deployed to the Cal.com production app.
  • Please review our Contributing Guidelines if you haven't already.
  • Make sure your PR title follows the Conventional Commits format.

A maintainer will review your PR soon. Thanks for contributing!

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55baa9ca-bf73-4784-ae69-137c65700815

📥 Commits

Reviewing files that changed from the base of the PR and between 9104545 and 383a483.

📒 Files selected for processing (13)
  • packages/app-store/analytics.services.generated.ts
  • packages/app-store/apps.browser.generated.tsx
  • packages/app-store/apps.keys-schemas.generated.ts
  • packages/app-store/apps.metadata.generated.ts
  • packages/app-store/apps.schemas.generated.ts
  • packages/app-store/apps.server.generated.ts
  • packages/app-store/bookerApps.metadata.generated.ts
  • packages/app-store/calendar.services.generated.ts
  • packages/app-store/crm.apps.generated.ts
  • packages/app-store/payment.services.generated.ts
  • packages/app-store/redirect-apps.generated.ts
  • packages/app-store/video.adapters.generated.ts
  • packages/features/bookings/lib/handleConfirmation.ts

📝 Walkthrough

Walkthrough

This PR updates twelve auto-generated app-store configuration files to use consistent formatting: removing trailing semicolons from imports, converting all object keys to quoted strings, and condensing multi-line ternary expressions to single-line format. Functionally, all service maps, component mappings, and dynamic imports remain identical. In addition, the booking confirmation handler now conditionally adds a location field to booking metadata when a meetingUrl is present for both recurring and single bookings.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning All changes are regenerated app-store files (formatting/code generation updates) and one functional change in handleConfirmation.ts. Regenerated files are build artifacts that likely changed due to tooling updates unrelated to the issue fix. Exclude generated files from this PR or clarify why they were regenerated. The functional fix in handleConfirmation.ts is in-scope, but the 12 regenerated app-store files appear to be unrelated formatting changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing booking location to use meetingUrl on confirmation for self-hosted instances.
Description check ✅ Passed The description clearly explains the bug, root cause, and fix, relating directly to the changeset in handleConfirmation.ts.
Linked Issues check ✅ Passed The PR fixes issue #18259 by updating handleConfirmation.ts to set location=meetingUrl when confirmed, directly addressing the raw integration slug problem.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot removed the Stale label Jun 14, 2026
@CLAassistant

CLAassistant commented Jun 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync self-hosting size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conferencing Location does not fill - SelfHosted

2 participants