fix: update booking location to meetingUrl on confirmation (Self-Hosted)#29553
fix: update booking location to meetingUrl on confirmation (Self-Hosted)#29553SparshGarg999 wants to merge 1 commit into
Conversation
When a booking requiring confirmation is approved, the integration slug (e.g. integrations:office365_video, integrations:discord_video) was stored as the booking location. After confirmation, the actual meeting URL was generated and stored only in metadata.videoCallUrl, but the location field was never updated. This caused calendar events and ICS files to display the raw integration slug instead of the actual conferencing link. Fix: update the Prisma booking.update() call for both single and recurring bookings to also set location = meetingUrl when a meetingUrl is successfully generated on confirmation. Fixes calcom#18259
|
Welcome to Cal.diy, @SparshGarg999! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThis PR updates twelve auto-generated app-store configuration files to use consistent formatting: removing trailing semicolons from imports, converting all object keys to quoted strings, and condensing multi-line ternary expressions to single-line format. Functionally, all service maps, component mappings, and dynamic imports remain identical. In addition, the booking confirmation handler now conditionally adds a 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Fixes conferencing location displaying raw integration slugs (e.g.
integrations:office365_video,integrations:discord_video) instead of the actual meeting URL in calendar events and ICS files for self-hosted instances.Root Cause
When a booking requiring confirmation is approved,
handleConfirmation.tsgenerates the actual meeting URL and stores it inmetadata.videoCallUrl. However, thelocationfield in the database was never updated - it remained as the raw integration slug set at booking creation time.Calendar events / ICS files read from the
locationfield, so attendees saw the slug instead of a clickable meeting link.Fix
In
handleConfirmation.ts, update the Prismabooking.update()call for both single and recurring bookings to also setlocation = meetingUrlwhenever ameetingUrlis successfully generated upon confirmation.Type of change
Checklist
Closes #18259