Skip to content

add support for ariaBrailleLabel and ariaBrailleRoleDescription #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lideen
Copy link
Contributor

@lideen lideen commented Sep 20, 2024

Was experiencing the same issues as described in #133. This is my fix for it. Noticed after the fact that that there was already a fix in #134, so feel free to close this in favor of that one if necessary.

@calebdwilliams
Copy link
Owner

My concern here is neither of these actually fix the issue in a sustainable way. I’ve been playing with a way to modify and polyfill the global types to keep things reconciled but haven’t had a lot of time to dedicate to open source lately.

@calebdwilliams
Copy link
Owner

I have a version of this in progress on the fix-ts branch if you want to look at it to see if it fixes your issues. I'm working through how best to test this right now.

@lideen
Copy link
Contributor Author

lideen commented Oct 4, 2024

I have a version of this in progress on the fix-ts branch if you want to look at it to see if it fixes your issues. I'm working through how best to test this right now.

Tried to run the version on your branch, but ran into a TS error when trying to compile my project:

types.d.ts(23,26): error TS2304: Cannot find name 'CustomStateSet'

Didn't have time to investigate that much tbh, might just be on my end, but thought I'd share.

@calebdwilliams
Copy link
Owner

@lideen That makes sense. I've updated the file.

@abeggchr abeggchr mentioned this pull request Dec 9, 2024
@calebdwilliams
Copy link
Owner

@lideen If this is still an issue for you, I've updated my fix-ts branch. Feel free to give that a go.

@calebdwilliams
Copy link
Owner

I've published a prerelease of 2.x at version 2.0.0-next.1. LMK if that fixes your issue.

@lideen
Copy link
Contributor Author

lideen commented Feb 17, 2025

@calebdwilliams got around to testing it now, seems to work 👍. Thank you 🙏

@lideen lideen closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants